Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with periodic action #2705

Closed
wants to merge 3 commits into from
Closed

Fix issue with periodic action #2705

wants to merge 3 commits into from

Conversation

syntaxi
Copy link

@syntaxi syntaxi commented Dec 25, 2016

Fix NPE error when attempting to use delayManager and periodicAction due to an instance of not checking the actionId before attempting to remove the periodicAction.

@GooeyHub
Copy link
Member

Hooray Jenkins reported success with all tests good!

@oniatus
Copy link
Contributor

oniatus commented Dec 26, 2016

Duplicate of #2670?

@Cervator
Copy link
Member

Yep looks like great minds think alike :-)

I just merged #2670 so will close this as effectively covered by the other PR. Thanks both!

@Cervator Cervator closed this Dec 27, 2016
@syntaxi syntaxi deleted the Fix_issue_with_periodicAction branch December 29, 2016 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syntaxi @GooeyHub @oniatus @Cervator