update

MrWangJustToDo · Nov 25, 2024 · 53d4f0a · 53d4f0a
1 parent 3c8a603
commit 53d4f0a
Show file tree

Hide file tree

Showing 5 changed files with 159 additions and 63 deletions.
diff --git a/packages/myreact-reconciler/src/processState/feature.ts b/packages/myreact-reconciler/src/processState/feature.ts
@@ -5,7 +5,14 @@ import { isErrorBoundariesComponent } from "../dispatchErrorBoundaries";
 import { listenerMap } from "../renderDispatch";
 import { prepareUpdateOnFiber, type MyReactFiberNode } from "../runtimeFiber";
 import { getInstanceOwnerFiber } from "../runtimeGenerate";
-import { getCurrentDispatchFromFiber, getElementName, onceWarnWithKeyAndFiber, safeCallWithCurrentFiber, syncFlush } from "../share";
+import {
+  enableLogForCurrentFlowIsRunning,
+  getCurrentDispatchFromFiber,
+  getElementName,
+  onceWarnWithKeyAndFiber,
+  safeCallWithCurrentFiber,
+  syncFlush,
+} from "../share";
 
 import type { MyReactHookNode } from "../runtimeHook";
 import type { MyReactComponent, MyReactInternalInstance, RenderFiber, UpdateQueue } from "@my-react/react";
@@ -95,14 +102,16 @@ export const processState = (_params: UpdateQueue) => {
         );
       } else if (!isErrorBoundariesComponent(ownerFiber)) {
         const triggeredElementName = getElementName(ownerFiber);
-        
+
         const currentElementName = getElementName(currentCFiber);
 
-        onceWarnWithKeyAndFiber(
-          currentRFiber,
-          `updateWhenCurrentFlowIsRunning-${triggeredElementName}`,
-          `[@my-react/react] trigger an update for ${triggeredElementName} when current update flow is running, this is a unexpected behavior, please make sure current render function for ${currentElementName} is a pure function`
-        );
+        if (enableLogForCurrentFlowIsRunning.current) {
+          onceWarnWithKeyAndFiber(
+            currentRFiber,
+            `updateWhenCurrentFlowIsRunning-${triggeredElementName}`,
+            `[@my-react/react] trigger an update for ${triggeredElementName} when current update flow is running, this is a unexpected behavior, please make sure current render function for ${currentElementName} is a pure function`
+          );
+        }
       }
 
       lastRenderComponentFiber = currentCFiber;
@@ -156,12 +165,16 @@ export const processState = (_params: UpdateQueue) => {
         );
       } else if (!isErrorBoundariesComponent(ownerFiber)) {
         const triggeredElementName = getElementName(ownerFiber);
+
         const currentElementName = getElementName(currentCFiber);
-        onceWarnWithKeyAndFiber(
-          currentRFiber,
-          `updateWhenCurrentFlowIsRunning-${triggeredElementName}`,
-          `[@my-react/react] trigger an update for ${triggeredElementName} when current update flow is running, this is a unexpected behavior, please make sure current render function for ${currentElementName} is a pure function`
-        );
+
+        if (enableLogForCurrentFlowIsRunning.current) {
+          onceWarnWithKeyAndFiber(
+            currentRFiber,
+            `updateWhenCurrentFlowIsRunning-${triggeredElementName}`,
+            `[@my-react/react] trigger an update for ${triggeredElementName} when current update flow is running, this is a unexpected behavior, please make sure current render function for ${currentElementName} is a pure function`
+          );
+        }
       }
       lastRenderComponentFiber = currentCFiber;
       lastRenderComponentTimeStep = now;

diff --git a/packages/myreact-reconciler/src/share/elementType.ts b/packages/myreact-reconciler/src/share/elementType.ts
@@ -36,6 +36,15 @@ type ReturnTypeFromElement = {
 
 const emptyProps = {};
 
+const checkIsMyReactElement = (element: MyReactElementNode) => {
+  if (isValidElement(element)) {
+    const isMyReactElement = element._jsx || element._legacy;
+    if (!isMyReactElement) {
+      devWarn(`[@my-react/react] look like current element is not a valid @my-react element %o`, element);
+    }
+  }
+}
+
 export const getElementTypeFromType = (type: MyReactComponentType): MyReactComponentType => {
   if (typeof type === "object") {
     switch (type[TYPEKEY]) {
@@ -51,6 +60,10 @@ export const getElementTypeFromType = (type: MyReactComponentType): MyReactCompo
 export const getTypeFromElementNode = (element: MyReactElementNode): ReturnTypeFromElement => {
   let nodeType = NODE_TYPE.__initial__;
 
+  if (__DEV__) {
+    checkIsMyReactElement(element);
+  }
+
   if (isValidElement(element)) {
     return getTypeFromElement(element);
   } else {

diff --git a/packages/myreact-reconciler/src/share/env.ts b/packages/myreact-reconciler/src/share/env.ts
@@ -19,3 +19,5 @@ export const currentCallingFiber = createRef<MyReactFiberNode | null>(null);
 export const fiberToDispatchMap = new MyWeakMap() as WeakMap<MyReactFiberNode, CustomRenderDispatch>;
 
 export const enableFiberForLog = createRef(false);
+
+export const enableLogForCurrentFlowIsRunning = createRef(false);
Original file line number	Diff line number	Diff line change
Expand Up		@@ -19,3 +19,5 @@ export const currentCallingFiber = createRef<MyReactFiberNode \| null>(null);
		export const fiberToDispatchMap = new MyWeakMap() as WeakMap<MyReactFiberNode, CustomRenderDispatch>;

		export const enableFiberForLog = createRef(false);

		export const enableLogForCurrentFlowIsRunning = createRef(false);