Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker environment #18

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Add docker environment #18

merged 3 commits into from
Jan 21, 2022

Conversation

kitoriaaa
Copy link
Contributor

Summary

Add Dockerfile and example Makefile. You can run demo just by customizing mount volumes for input/output images directory on Makefile.
#3

Build docker image

make docker-build

Run

Customize mount volumes for input/output directory on Makefile
docker run -it --rm --gpus all -v `pwd`:/workspace -v <input images dir>:/input -v <output images dir>:/output anime2sketch
Run container make docker-run

if you run cpu only, you have to fix Dockerfile CMD to CMD [ "python", "test.py", "--dataroot", "/input", "--load_size", "512", "--output_dir", "/output" ] and Makefile docker-run to docker run -it --rm -v `pwd`:/workspace -v `pwd`/images/input:/input -v `pwd`/images/output:/output anime2sketch

@Mukosame
Copy link
Owner

Hi @kitoriaaa , thanks a lot for your great commit!
I would just request one follow-up: would you mind adding the above instruction to README.md, and also add your name proudly to the updates (like https://github.com/Mukosame/Anime2Sketch/blame/master/README.md#L12)?

@kitoriaaa
Copy link
Contributor Author

Hi @Mukosame , thanks feedback.
I have added docker instruction to README.md

@Mukosame Mukosame merged commit 46342c2 into Mukosame:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants