Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed spelling of verification in user_verification_email env #435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AngeloB-AIS
Copy link
Collaborator

@AngeloB-AIS AngeloB-AIS commented Oct 23, 2024

Description

Fixed spelling of "VERIFICATION" in "USER_VERIFICATION_EMAIL" variable in .env.example

Related Issue

None

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Connector (Destination or Source Connector)
  • Breaking change (fix or feature that would impact existing functionality)
  • Styling change
  • Documentation update
  • Refactoring
  • Chore

How Has This Been Tested?

OSS users have been having to fix it themselves to get past the email verification feature.

Checklist:

  • Ensure a branch name is prefixed with feature, bugfix, hotfix, release, style or chore followed by / and branch name e.g feature/add-salesforce-connector
  • Added unit tests for the changes made (if required)
  • Have you made sure the commit messages meets the guidelines?
  • Added relevant screenshots for the changes
  • Have you tested the changes on local/staging?
  • Added the new connector in rollout.rb
  • Have you updated the version number of the gem?
  • Have you ensured that your changes for new connector are documented in the docs repo or relevant documentation files?
  • Have you updated the run time dependency in multiwoven-integrations.gemspec if new gems are added
  • Have you made sure the code you have written follows the best practises to the best of your knowledge?

@AngeloB-AIS
Copy link
Collaborator Author

@CodiumAI-Agent /review

@AngeloB-AIS
Copy link
Collaborator Author

@CodiumAI-Agent /describe

@CodiumAI-Agent
Copy link

Title

fix: fixed spelling of verification in user_verification_email env


User description

Description

Fixed spelling of "VERIFICATION" in "USER_VERIFICATION_EMAIL" variable in .env.example

Related Issue

None

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Connector (Destination or Source Connector)
  • Breaking change (fix or feature that would impact existing functionality)
  • Styling change
  • Documentation update
  • Refactoring
  • Chore

How Has This Been Tested?

OSS users have been having to fix it themselves to get past the email verification feature.

Checklist:

  • Ensure a branch name is prefixed with feature, bugfix, hotfix, release, style or chore followed by / and branch name e.g feature/add-salesforce-connector
  • Added unit tests for the changes made (if required)
  • Have you made sure the commit messages meets the guidelines?
  • Added relevant screenshots for the changes
  • Have you tested the changes on local/staging?
  • Added the new connector in rollout.rb
  • Have you updated the version number of the gem?
  • Have you ensured that your changes for new connector are documented in the docs repo or relevant documentation files?
  • Have you updated the run time dependency in multiwoven-integrations.gemspec if new gems are added
  • Have you made sure the code you have written follows the best practises to the best of your knowledge?

PR Type

Bug fix


Description

  • Corrected the spelling of the USER_EMAIL_VERIFICATION environment variable in the .env.example file to ensure proper functionality.
  • This change addresses an issue where users had to manually correct the spelling to proceed with email verification.

Changes walkthrough 📝

Relevant files
Bug fix
.env.example
Fix spelling error in environment variable name                   

.env.example

  • Corrected the spelling of the USER_EMAIL_VERIFICATION environment
    variable.
  • Ensured consistency in environment variable naming.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @@ -30,7 +30,7 @@ REDIS_URL=redis://redis:6379/0
    # This environment variable is used to skip user email verification after signup.
    # Set to false for local testing. When set to true, ensure SMTP credentials are
    # configured correctly so that verification emails can be sent to users.
    USER_EMAIL_VERFICATION=false
    USER_EMAIL_VERIFICATION=false
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @AngeloB-AIS can we please also make sure where this env is used, whether right spelling is being used or not?
    Or have you already verified that?

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hey, just seeing this @sumitd94. The misspelling is only present in this .env.example file.
    Screenshot 2024-11-05 at 8 46 01 PM
    Screenshot 2024-11-05 at 8 45 49 PM

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants