MCR-3046 allow id generation independent from actual storage #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebhofmann
force-pushed
the
issues/MCR-3046_allow_id_generation_independent_from_actual_storage
branch
from
d9d8521
to
9fea7c7
Compare
rsteph-de
requested changes
Feb 19, 2024
|
|
||
| try ( | ||
| FileChannel channel = FileChannel.open(cacheFile, StandardOpenOption.WRITE, | ||
| StandardOpenOption.SYNC, StandardOpenOption.CREATE);){ |
There was a problem hiding this comment.
shouldn't we use here at least a FileLock, too?
A ReentrantWriteLock is probably not necessary.
There was a problem hiding this comment.
It is only used by the migration Command.
There was a problem hiding this comment.
i added javadoc that the caller has to do locking. The method should only be rarely used anyway.
mycore-base/src/main/java/org/mycore/datamodel/common/MCRFileBaseCacheObjectIDGenerator.java
Show resolved
Hide resolved
| @@ -0,0 +1,58 @@ | |||
| package org.mycore.datamodel.common; | |||
There was a problem hiding this comment.
MyCoRe License Header is missing
| throws IOException { | ||
| buffer.clear(); | ||
| channel.position(0); | ||
| buffer.putInt(nextID.getNumberAsInteger()); |
There was a problem hiding this comment.
For me if would be nicer to see the Integer not as byte, but readable string in the file - or maybe store the whole MCRObjectID-String?
So it would be easier to Debug the MyCoRe-System.
There was a problem hiding this comment.
i store the entire id as string now
* store ids as strings to make debugging easier * add a docs to setNextFreeId * add missing copyrights
kkrebs
deleted the
issues/MCR-3046_allow_id_generation_independent_from_actual_storage
branch
sebhofmann
added a commit
that referenced
this pull request
Feb 21, 2024
* 2023.06.x: MCR-3011 fix duplicate dateModified MCR-3030 Isolated the HTTP-client in use by MCRRESTResolver (#2051) MCR-3035 fix empty p tags in wcms MCR-3037 Added getUsableSpace() to MCRXMLFunctions (#2058) MCR-3038 MCRMETSDefaultGenerator.structureMets generates double logical ids MCR-3039 fix upload size detection and fix error messages (#2059) MCR-3040 fix XSLT 3 issues MCR-3041 rest api v 2 quirks (#2065) MCR-3041 rest api v 2 quirks (#2062) MCR-3046 allow id generation independent from actual storage (#2067)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.