MCR-3225 activate PMD rule AvoidReassigningLoopVariables #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- ruleset.xml: Language not supported
toKrause
reviewed
Nov 20, 2024
mycore-restapi/src/main/java/org/mycore/restapi/v2/MCRRestDerivateContents.java
Outdated
Show resolved
Hide resolved
toKrause
approved these changes
Nov 20, 2024
yagee-de
deleted the
issues/MCR-3225-enable-pmd-rule-category-java-bestpractices-xml-avoid-reassigning-loop-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.
This pull request adds a new method to retrieve the digest value, refactoring the MD5 digest calculation, and updating the ruleset configuration.
Enhancements to functionality:
mycore-base/src/main/java/org/mycore/common/digest/MCRDigest.java: Added a new methodgetValue()to return a copy of the digest value.Refactoring:
mycore-restapi/src/main/java/org/mycore/restapi/v2/MCRRestDerivateContents.java: Refactored thegetMD5Digestmethod to use theMCRMD5Digestclass for MD5 digest calculation.Configuration updates:
ruleset.xml: Uncommented the rule forAvoidReassigningLoopVariablesand removed the TODO comment.