-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCR-3339 Ensure usage of MCRResourceResolver with custom PMD rule #2424
Open
toKrause
wants to merge
1
commit into
2024.06.x
Choose a base branch
from
issues/MCR-3339_Ensure-usage-of-MCRResourceResolver-with-custom-PMD-rule
base: 2024.06.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MCR-3339 Ensure usage of MCRResourceResolver with custom PMD rule #2424
toKrause
wants to merge
1
commit into
2024.06.x
from
issues/MCR-3339_Ensure-usage-of-MCRResourceResolver-with-custom-PMD-rule
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8c87f1
to
3607053
Compare
please resolve conflict |
3607053
to
c774958
Compare
rebased |
golsch
requested changes
Feb 26, 2025
mycore-webtools/src/main/java/org/mycore/webtools/vue/MCRVueRootServlet.java
Outdated
Show resolved
Hide resolved
c774958
to
32f28b0
Compare
golsch
requested changes
Feb 27, 2025
mycore-webtools/src/main/java/org/mycore/webtools/vue/MCRVueRootServlet.java
Outdated
Show resolved
Hide resolved
mycore-webtools/src/main/java/org/mycore/webtools/vue/MCRVueRootServlet.java
Outdated
Show resolved
Hide resolved
32f28b0
to
e42ad8a
Compare
golsch
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vue part looks good for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.
Relies on #2423.