Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Move the release checklist out of the README #1391

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

oliverklee
Copy link
Contributor

Part of #1360

@oliverklee oliverklee added this to the 8.0.0 milestone Jan 25, 2025
@oliverklee oliverklee requested a review from JakeQZ January 25, 2025 10:54
@oliverklee oliverklee self-assigned this Jan 25, 2025
@oliverklee oliverklee removed the request for review from JakeQZ January 25, 2025 10:54
@oliverklee oliverklee marked this pull request as draft January 25, 2025 10:55
@coveralls
Copy link

coveralls commented Jan 25, 2025

Coverage Status

coverage: 97.062%. remained the same
when pulling e4567d2 on task/release-instructions
into bc4e250 on main.

Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out. Only changes on diff are heading levels and relative paths.

@JakeQZ JakeQZ marked this pull request as ready for review January 26, 2025 02:29
@JakeQZ
Copy link
Contributor

JakeQZ commented Jan 26, 2025

There's supposed to be a 're-run checks' button somewhere, but I'm darned if I can find it. No way the CI should have failed for this, which is only changes to .md files.

@JakeQZ
Copy link
Contributor

JakeQZ commented Jan 26, 2025

The tests failed due to internet connectivity issue.

WHERE HAS THE RE-RUN BUTTON GONE?

@oliverklee
Copy link
Contributor Author

The tests failed due to internet connectivity issue.

That's what I though as well. But then it turned out the GPG key for the PHPMD PHAR is no longer available:

Warning: Failed with error code 404: Key not found on keyserver

That's why I created #1394.

@oliverklee
Copy link
Contributor Author

oliverklee commented Jan 26, 2025

WHERE HAS THE RE-RUN BUTTON GONE?

For me, it's in the actions runner screen, not in the PR:

rerun

@oliverklee oliverklee force-pushed the task/release-instructions branch from 2db1384 to e4567d2 Compare January 26, 2025 10:10
@oliverklee
Copy link
Contributor Author

Now that #1394 has been merged and the build (hopefully) is green again, I've rebased this PR. Hopefully the build will be green.

@oliverklee oliverklee merged commit 97cf851 into main Jan 26, 2025
28 checks passed
@oliverklee oliverklee deleted the task/release-instructions branch January 26, 2025 10:11
@JakeQZ
Copy link
Contributor

JakeQZ commented Jan 26, 2025

WHERE HAS THE RE-RUN BUTTON GONE?

For me, it's in the actions runner screen, not in the PR:

Finally found it. You have to navigate to the specific workflow run first, by clicking on the title of the associated PR in the list of all workflow runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants