Upgrade app UI and address old issues #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the design more like a messaging app, including showing what the user said to Mycroft. Currently, those cards will only show up if the connection to Mycroft was successful. + Added lighter user cards displaying what the user said + Mycroft cards on the other side from the user cards - Removed "Mycroft says:"
Long presses on utterances will show an option menu. Currently, the user's utterances can be copied and resent and Mycroft's utterances can be copied and shared. It is easy to add and implement new options. This addresses issue #53. + Options menu on long click
Changed the TTS switch to a button with icons. It should be more intuitive and look better. * Changed the button - Using Material Design icons
Create a button to toggle between keyboard mode and speech input mode. This will theoretically allow for a version without Google Play Services using a keyboard as input. + Keyboard toggle button * Changed the FAB to another larger, centered button in microphone mode
skraynick
reviewed
Feb 18, 2019
|
I changed line 123 to use |
|
I would just like to point out that Chuck Norris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade app UI and address old issues
This PR updates the app's UI to be more useful and solve several old issues.
Changes:
Screenshots
Microphone mode
Keyboard mode
Keyboard input is sent to Mycroft
Long press on Mycroft utterance
Long press on user utterance