Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyTZ for Python 3.10 support #122

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Conversation

krisgesling
Copy link
Contributor

Description

The pinned version of PyTZ is failing on Python 3.10.

This updates the PyTZ dependency to provide support for this version of Python.

Type of PR

  • Bugfix

Testing

Voight Kampff integration tests should pass.

CLA

  • Yes

@krisgesling krisgesling merged commit c8585ec into 21.02 Mar 22, 2022
@krisgesling krisgesling deleted the bugfix/py310-support branch March 22, 2022 13:51
@LadyNamedLaura
Copy link

@krisgesling while this fixes the problem short term, I think pinning pytz to a specific version is just not a great idea. as said in #120, on the one hand pytz contains data that needs to be kept up-to-date, on the other hand all mycroft skills get installed into the same virtualenv, so over-constraining your dependencies can cause issues with other skills.

@krisgesling
Copy link
Contributor Author

Yeah, our intention is to automate version updates of dependencies so we don't have this situation, but we also ensure that the packages installed result in a complete and working build.

It's also harder with projects like pytz that use the YYYY.release format of versioning as it doesn't tell us if there are any breaking changes or if it's purely an update of the timezones etc. So we really need to have the integration tests confirm that each version is compatible before we release it.

In the past, we had all dependencies open and only pinned them when a problem was detected however this means that for some period of time, everyone installing the software gets a broken build. Whilst that can still happen with outdated dependencies, it's far less common (IMO).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ancient version of pytz isn't compatible with modern python versions
2 participants