Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #121 #122

Merged
merged 1 commit into from
May 1, 2023
Merged

Fix issue #121 #122

merged 1 commit into from
May 1, 2023

Conversation

Tony763
Copy link

@Tony763 Tony763 commented Jan 11, 2023

Description

This PR fixes crash reported by @Ramblurr #121 occuring while informing user, that skill do not have connection to HA instance after running _setup(). Speaking dialog from error.setup cause error as it mean to inform about errors in setup stage and need aditional content field. Dialog from error.offline should be used in this option as we are pass setup stage and checking connection to HA instance.

Type of PR

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Copy link
Collaborator

@stratus-ss stratus-ss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this, but it looks fine. The logic is sound

@stratus-ss stratus-ss merged commit 13b001c into MycroftAI:20.08 May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants