-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic GUI for Sensors #84
Conversation
I will also add binary sensors when #82 is merged. |
@krisgesling can you take a look at this? I am not familiar with the GUI |
It seems that the background image is persistant and stays also on other GUIs like settings or naptime. @krisgesling is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, exciting to see GUI elements coming in!
The image remaining across Skills is something we have to look at. Not a problem with your implementation. However I've made some little suggestions below that should work better.
I've also wondered if we should add an intent to display the HomeAssistants own GUI.
There's a handy self.gui.show_url()
method.
@krisgesling I had a very similar idea, but wanted to start it as a stand alone skill, because I was not sure if it fits: https://github.com/pfefferle/skill-open-homeassistant But now I will skip the idea and add it directly to this plugin. |
@krisgesling see #91 |
@krisgesling works perfect, thanks for the feedback! |
Yeah to clarify, I didn't mean to use the web view instead of QML. Personally, I'd like us to end up with native QML views for all of the interactions, state reporting etc. And you could obviously toggle things from the GUI like turning lights on and off. I think where the web view comes in is that a lot of HomeAssistant users have already spent a lot of time designing custom interfaces that suit their personal setup. So it would be good to let them use those same GUI's on their Mycroft devices if they have them and want to. These might be based on location groupings like everything in the kitchen, or to serve different functional purposes like alarm / cctv monitoring. It will require some thinking around how we people can configure what is shown when, and I don't know how well they will display on a small screen, or if there's a way to show a lovelace view without the nav header which takes up a bunch of room especially if you have multiple tabs. Also pinging @dschweppe as I know he's keen to input around the design side of things. |
Should we open an issue for that? I think it is far bigger than the scope of that PR. I simply wanted to add a visual to the status check of the several sensors. @krisgesling can you re-review my changes? |
|
"Open Home Assistant" was added with #91 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I haven't run it on an install so would be great if someone could do that - but the new Github Actions should also catch any major issues.
The GUI looks good on the few sizes I tested.
Small optional suggestion below
sensor_states = self.translate_namedvalues( | ||
'homeassistant.sensor.cover.state') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could move these to initialize()
so we only have to do it once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing so I'll merge this - and refactoring can happen in a follow up PR if there's interest in it.
Description
If you ask about a state of a (binary)sensor, it will display the value in a very basic form.
Type of PR
Testing
Say "What is the value of {Binary Sensors Name}."