Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the text box entry keyboard controls #528

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

MyreMylar
Copy link
Owner

also fix a couple of other minor bugs noticed in testing

also fix a couple of other minor bugs noticed in testing
also fix a couple of other minor bugs noticed in testing
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 84.23913% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 96.32%. Comparing base (a377016) to head (860bb78).

Files Patch % Lines
pygame_gui/elements/ui_text_entry_box.py 82.23% 27 Missing ⚠️
pygame_gui/core/text/text_box_layout_row.py 91.66% 1 Missing ⚠️
pygame_gui/windows/ui_file_dialog.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
+ Coverage   95.59%   96.32%   +0.73%     
==========================================
  Files          84       84              
  Lines       11800    11896      +96     
==========================================
+ Hits        11280    11459     +179     
+ Misses        520      437      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MyreMylar
Copy link
Owner Author

Need to add some tests to this.

@MyreMylar MyreMylar merged commit 693945e into main Mar 4, 2024
22 checks passed
@MyreMylar MyreMylar deleted the text-entry-box-controls-2 branch April 1, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant