At/account #47
Merged
At/account #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepbook/sources/pool/account.move
Outdated
| // TODO: use Bag instead of direct dynamic fields | ||
| /// Owned by user, this is what's passed into pools | ||
| public struct Account has key, store { | ||
| const MAX_TRADE_CAPS: u64 = 10; |
There was a problem hiding this comment.
why do we need this limit?
There was a problem hiding this comment.
we can't make it unlimited since vector can become too large. this constraint reduces the possible attack vectors
There was a problem hiding this comment.
Agreed on the limit, to rephrase better, the "10" is just a placeholder right?
It could be 1K for instance (or the max size of the vector) [we'll decide that later?]
There was a problem hiding this comment.
Hmmmm let's make it 1k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.