[fastpath] send certified transactions to fast path #20021
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
8ea4bce to
7068af0
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
7068af0 to
ab25d1a
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
91fa8d3 to
f1b0d1b
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
f1b0d1b to
a23deb9
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
a23deb9 to
c74c272
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
c74c272 to
38fd8b5
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
38fd8b5 to
03dd704
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
03dd704 to
32bbf8c
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
32bbf8c to
53c14dc
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
53c14dc to
5690c52
Compare
| if self | ||
| .accept_votes | ||
| .stake() | ||
| .checked_sub(reject_votes.stake()) | ||
| .unwrap() | ||
| < committee.quorum_threshold() | ||
| { | ||
| return None; | ||
| } |
There was a problem hiding this comment.
The rejected_votes.stake() refers to the single transaction of index idx . Why can't the block be certified in this case? Am I missing something?
There was a problem hiding this comment.
Yeah I using certified block to mean not just the block is certified, but all its transactions are certified to be accepted or rejected. Added comment.
There was a problem hiding this comment.
Ok got it, it makes sense.
Looking on the evolution of the code I start getting the feeling that the certificate term gets overused in different flows (commit rule, fast path txes) and it could result to confusions - especially in the future or new people looking into this.
I would like your view on this , but I believe we might need to somehow differentiate the "fast path certificates" from the "consensus certificate". For example maybe we can introduce the "transactions" concept.
take_certified_output->take_tx_certified_outputortake_transactions_certified_outputcertified_output->transactions_certified_outputBlockOutputBatch::Certified->BlockOutputBatch::TransactionsCertified, orBlockOutputBatch::TxCertifiedorBlockOutputBatch::WithCertifiedTransactions
There was a problem hiding this comment.
I agree certificate is already overloaded, for example it can mean certified block in Narwhal, certified transaction in Sui and certified leaders in Mysticeti commit rule.
For a given class of entities (one of blocks, transactions, leaders), do we ever certify them in different ways? I think we do not, so we may just need to be precise on what is being certified. For example in commit rules, we need to use CertifiedLeader / LeaderCertificate instead of just certificate.
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
7b5a8fb to
b6e2da7
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
b6e2da7 to
a77408d
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
a77408d to
66c96ea
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
66c96ea to
f0833c8
Compare
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
f0833c8 to
3323a0d
Compare
|
Through prototyping, I start to think that we should explore the alternative where votes are not enforced to be in the causal history of the voter, and total votes are tracked in a data structure ( |
mwtian
force-pushed
the
tmw/consensus-vote
branch
from
3323a0d to
d77372a
Compare
mwtian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Description
Keep track of accept and reject votes from blocks. For certified blocks where every transaction has a quorum of accept or reject votes, send them to fastpath.
Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.