Upgrade errors for additive and deponly policies #20695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
upgrade-additive-deponly
branch
from
4f6d491 to
137b942
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
approved these changes
Dec 22, 2024
...c/unit_tests/snapshots/sui__upgrade_compatibility__upgrade_compatibility_tests__deponly.snap
Outdated
Show resolved
Hide resolved
...nit_tests/snapshots/sui__upgrade_compatibility__upgrade_compatibility_tests__type_param.snap
Outdated
Show resolved
Hide resolved
| impl InclusionCheckMode for CliInclusionCheckMode { | ||
| type Error = Vec<UpgradeCompatibilityModeError>; | ||
|
|
||
| fn module_name_mismatch(&mut self, _old_address: &Identifier, _new_address: &Identifier) {} |
There was a problem hiding this comment.
Is a module name mismatch even possible? I thought we performed this check by first lining up modules by their name. Should this case be removed from the interface?
There was a problem hiding this comment.
I think the move here is to bundle name and address check into a single module_id_mismatch as compatibility check does so at least we don't have an extra function just for the name check. I'll do it in another smaller PR since it affects code outside of the sui crate.
jordanjennings-mysten
force-pushed
the
upgrade-additive-deponly
branch
from
137b942 to
ea81150
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
upgrade-additive-deponly
branch
from
ea81150 to
5362a57
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
upgrade-additive-deponly
branch
from
5362a57 to
d2a0931
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
upgrade-additive-deponly
branch
from
d2a0931 to
1d359f2
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support additive and deponly policies for upgrade errors
Test plan
snapshot testing
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.