docs: update conventions to latest Move features #20791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
github-actions
bot
added
the
Type: Documentation
ronny-mysten
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Thanks @thounyy ! I added some style guide comments that you can address or leave for me to update if you're okay with all of them.
thounyy
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
sblackshear
reviewed
Jan 6, 2025
sblackshear
reviewed
Jan 6, 2025
Co-authored-by: ronny-mysten <[email protected]>
|
great review @ronny-mysten thanks for taking the time! @sblackshear I also applied changes for your comments in this commit. |
thounyy
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
ronny-mysten
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Move Conventions on Sui from the previous doc written by @josemvcerqueira based on the latest changes in Move 2024.
Feel free to suggest changes!