Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy extension wallet #20806

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 0 additions & 2 deletions .changeset/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
"updateInternalDependencies": "minor",
"privatePackages": false,
"ignore": [
"sui-wallet",
"@mysten/core",
"sponsored-transactions",
"kiosk-demo",
"kiosk-cli",
Expand Down
30 changes: 1 addition & 29 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ module.exports = {
'build',
'dist',
'coverage',
'apps/icons/src',
'next-env.d.ts',
'doc/book',
'external-crates',
Expand Down Expand Up @@ -83,33 +82,6 @@ module.exports = {
'import/no-cycle': ['error'],
},
},
{
files: ['apps/wallet/**/*'],
rules: {
'react/display-name': 'off',
'import/no-duplicates': ['error'],
'@typescript-eslint/consistent-type-imports': [
'error',
{
prefer: 'type-imports',
disallowTypeAnnotations: true,
fixStyle: 'inline-type-imports',
},
],
'@typescript-eslint/unified-signatures': 'error',
'@typescript-eslint/parameter-properties': 'error',
'no-console': ['warn'],
'@typescript-eslint/no-non-null-assertion': 'off',
},
},
{
files: ['apps/wallet/src/**/*.test.*', 'apps/wallet/src/**/*.spec.*'],

rules: {
// Allow any casting in tests:
'@typescript-eslint/no-explicit-any': 'off',
},
},
{
files: ['dapps/kiosk/**/*'],
rules: {
Expand All @@ -127,7 +99,7 @@ module.exports = {
},
},
{
files: ['sdk/ledgerjs-hw-app-sui/**/*', 'apps/wallet/**/*'],
files: ['sdk/ledgerjs-hw-app-sui/**/*'],
rules: {
// ledgerjs-hw-app-sui and wallet use Buffer
'no-restricted-globals': ['off'],
Expand Down
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ CHANGELOG.md
/crates/sui-core/src/consensus_handler.rs @MystenLabs/consensus
/crates/sui-core/src/consensus_adapter.rs @MystenLabs/consensus

apps/ @MystenLabs/fe-and-apps
sdk/ @MystenLabs/sdk-reviewers
sdk/kiosk @MystenLabs/kiosk-sdk-reviewers
sdk/wallet-standard @MystenLabs/wallet-kit-reviewers
23 changes: 1 addition & 22 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ jobs:
diff:
runs-on: ubuntu-latest
outputs:
isWallet: ${{ (steps.turbo.outputs.packages && contains(fromJson(steps.turbo.outputs.packages), 'sui-wallet')) }}
isTypescriptSDK: ${{ (steps.turbo.outputs.packages && contains(fromJson(steps.turbo.outputs.packages), '@mysten/sui')) }}
isGraphQlTransport: ${{ (steps.turbo.outputs.packages && contains(fromJson(steps.turbo.outputs.packages), '@mysten/graphql-transport')) }}
isRust: ${{ steps.diff.outputs.isRust }}
Expand All @@ -24,7 +23,7 @@ jobs:
localnet:
name: Localnet
needs: diff
if: needs.diff.outputs.isTypescriptSDK == 'true' || needs.diff.outputs.isWallet == 'true' || needs.diff.outputs.isRust == 'true'
if: needs.diff.outputs.isTypescriptSDK == 'true' || needs.diff.outputs.isRust == 'true'
runs-on: ubuntu-ghcloud
services:
postgres:
Expand Down Expand Up @@ -58,8 +57,6 @@ jobs:
cache: 'pnpm'
- name: Install dependencies
run: pnpm install --frozen-lockfile
# - name: Install Playwright Browsers
# run: pnpm --filter sui-wallet playwright install --with-deps chromium

- name: Set env
run: |
Expand All @@ -74,24 +71,6 @@ jobs:
if: ${{ needs.diff.outputs.isGraphQlTransport == 'true' || needs.diff.outputs.isRust == 'true' }}
run: pnpm dlx concurrently --kill-others --success command-1 "$E2E_RUN_LOCAL_NET_CMD" 'pnpm --filter @mysten/graphql-transport test:e2e'

# - name: Run Local net
# run: cargo run --bin sui -- start --with-faucet --force-regenesis --epoch-duration-ms 10000 &
# - name: Set Wallet env
# run: echo "API_ENV=local" > "$PWD/apps/wallet/configs/environment/.env"
# - name: Build Wallet
# # need to run Wallet e2e when its upstream(TS SDK and Rust) or itself is changed
# if: ${{ needs.diff.outputs.isWallet == 'true' || needs.diff.outputs.isRust == 'true' || needs.diff.outputs.isTypescriptSDK == 'true'}}
# run: pnpm wallet build
# - name: Run Wallet e2e tests
# if: ${{ needs.diff.outputs.isWallet == 'true' || needs.diff.outputs.isRust == 'true' || needs.diff.outputs.isTypescriptSDK == 'true'}}
# run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- pnpm --filter sui-wallet playwright test
# - uses: actions/upload-artifact@v3
# if: always()
# with:
# name: playwright-report-wallet
# path: apps/wallet/playwright-report/
# retention-days: 30

# Run e2e test against localnet built on the devnet branch for backward compatibility check
local_devnet_branch:
name: Local Network Built on devnet branch
Expand Down
16 changes: 0 additions & 16 deletions .github/workflows/turborepo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,19 +83,3 @@ jobs:
GOOGLE_KEY_NAME_VERSION: ${{ secrets.GOOGLE_KEY_NAME_VERSION }}
E2E_GCP_KMS_TEST_ENABLE: ${{ env.E2E_GCP_KMS_TEST_ENABLE }}
run: pnpm turbo test

# Pack wallet extension and upload it as an artifact for easy developer use:
- name: Wallet Extension Has Changes?
id: wallet-diff
continue-on-error: true
run: pnpm dlx turbo-ignore sui-wallet
- name: Wallet Extension Preview Package
if: ${{ steps.wallet-diff.outcome == 'failure' }}
run: pnpm --filter sui-wallet pack:zip
- uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # [email protected]
if: ${{ steps.wallet-diff.outcome == 'failure' }}
with:
name: wallet-extension
path: apps/wallet/web-ext-artifacts/*
if-no-files-found: error
retention-days: 7
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
!/*.js

# ignore generated files
/apps/icons/src
npm-debug.log*
package-lock.json
yarn-debug.log*
Expand Down
3 changes: 0 additions & 3 deletions apps/core/README.md

This file was deleted.

53 changes: 0 additions & 53 deletions apps/core/package.json

This file was deleted.

47 changes: 0 additions & 47 deletions apps/core/src/api/SentryHttpTransport.ts

This file was deleted.

27 changes: 0 additions & 27 deletions apps/core/src/components/KioskClientProvider.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions apps/core/src/css.d.ts

This file was deleted.

56 changes: 0 additions & 56 deletions apps/core/src/hooks/__tests__/useFormatCoin.test.ts

This file was deleted.

52 changes: 0 additions & 52 deletions apps/core/src/hooks/nameService.ts

This file was deleted.

Loading
Loading