sui-rpc: rework proto files based on 'buf lint' #20837
Merged
+512
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework the sui package proto files based on suggestions from 'buf lint'. One of the suggestions is to ensure that services end with a common prefix `Service`. In order to gracefully transition to this for the release to mainnet, the renamed service `NodeService` and the old service `Node` will both be supported for a single release, after which the older `Node` service will be removed.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
ebmifa
approved these changes
Jan 9, 2025
johnjmartin
approved these changes
Jan 9, 2025
bmwill
merged commit c07e414
into
MystenLabs:releases/sui-v1.40.0-release
46 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the sui package proto files based on suggestions from 'buf lint'. One of the suggestions is to ensure that services end with a common prefix
Service. In order to gracefully transition to this for the release to mainnet, the renamed serviceNodeServiceand the old serviceNodewill both be supported for a single release, after which the olderNodeservice will be removed.Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.