Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sui-http: properly set TCP_NODELAY by default #20842

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

bmwill
Copy link
Contributor

@bmwill bmwill commented Jan 9, 2025

The configuration documentation stated that TCP_NODELAY was enabled by default but the actual default had it disabled. This patch corrects that and enables TCP_NODELAY by default.

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

The configuration documentation stated that TCP_NODELAY was enabled by
default but the actual default had it disabled. This patch corrects that
and enables TCP_NODELAY by default.
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 9:06pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 9:06pm

@bmwill bmwill temporarily deployed to sui-typescript-aws-kms-test-env January 9, 2025 21:05 — with GitHub Actions Inactive
@bmwill bmwill enabled auto-merge (squash) January 9, 2025 21:14
Copy link
Member

@mwtian mwtian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the unneccessary override(s) as well?

@bmwill bmwill merged commit 35d516b into MystenLabs:main Jan 9, 2025
46 checks passed
@bmwill bmwill deleted the tcp_nodelay branch January 9, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants