[RFC] [indexer-alt] Add object filter queries #20847
Draft
+254
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/indexer-alt-obj-info-queries
branch
from
03402fc to
2453720
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
reviewed
Jan 10, 2025
Comment on lines
+189
to
+197
| "(object_id = '\\x{}'::bytea AND cp_sequence_number <= {})", | ||
| hex::encode(&o.object_id), | ||
| o.cp_sequence_number | ||
| ) | ||
| }) | ||
| .collect::<Vec<_>>() | ||
| .join(" OR "); | ||
| let query = format!( | ||
| " | ||
| SELECT obj_versions.* |
There was a problem hiding this comment.
or filtering with postgres always makes me cry, it makes the query planner do inefficient stuff, usually. on graphql, what we've ended up doing is just to fetch the latest objects, and then filter in the application
Comment on lines
145
to
150
| max_cp_per_object AS ( | ||
| SELECT | ||
| object_id, | ||
| MAX(cp_sequence_number) AS max_cp_sequence_number | ||
| FROM | ||
| obj_info | ||
| WHERE | ||
| cp_sequence_number <= {view_checkpoint_number} | ||
| GROUP BY | ||
| object_id | ||
| ) |
There was a problem hiding this comment.
This would scan the entire table right? I see that it's needed to filter out older object entries that might match the filtering conditions ... can't think of a neat way around this though. We could use a window function to find the latest version in a single pass?
There was a problem hiding this comment.
Sorry this query is out-of-dated! I forgot to update it to use LEFT JOIN
lxfind
force-pushed
the
xun/indexer-alt-obj-info-queries
branch
from
2453720 to
a5bc652
Compare
lxfind
deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add queries that reads from the obj_info table. Still WIP, but sending out early.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.