Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adapter] Update how we handle type errors in some commands #20857

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

tzakian
Copy link
Contributor

@tzakian tzakian commented Jan 10, 2025

Description

Updates handling of type errors for some PTB commands as we were not properly converting the error type.

Test plan

CI + new transactional tests.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol: Adds a new protocol version that updates handling of certain type errors.
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@tzakian tzakian requested a review from a team January 10, 2025 18:37
@tzakian tzakian requested a review from mystenmark as a code owner January 10, 2025 18:37
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 6:38pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Jan 10, 2025 6:38pm
sui-kiosk ⬜️ Ignored (Inspect) Jan 10, 2025 6:38pm

Copy link
Contributor

@tnowacki tnowacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tzakian tzakian enabled auto-merge (squash) January 10, 2025 18:39
@tzakian tzakian merged commit 537c2f8 into main Jan 10, 2025
53 of 55 checks passed
@tzakian tzakian deleted the tzakian/type-errors-adapter branch January 10, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants