-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[indexer-alt-jsonrpc] Add basic objects JSONRPC API #20962
Open
lxfind
wants to merge
1
commit into
main
Choose a base branch
from
xun/indexer-alt-json-rpc-objects
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 23, 2025 21:54 — with
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/indexer-alt-json-rpc-objects
branch
from
January 23, 2025 21:59
e6ad39e
to
7962b99
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 23, 2025 21:59 — with
GitHub Actions
Inactive
emmazzz
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there plan to add some e2e transactional runner tests to this?
We should, but I may not have enough time for this tomorrow. |
lxfind
force-pushed
the
xun/indexer-alt-json-rpc-objects
branch
from
January 24, 2025 01:29
7962b99
to
4f73a7b
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 24, 2025 01:29 — with
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/indexer-alt-json-rpc-objects
branch
2 times, most recently
from
January 24, 2025 21:29
d6037d9
to
2d19c34
Compare
lxfind
force-pushed
the
xun/indexer-alt-json-rpc-objects
branch
from
January 24, 2025 21:30
2d19c34
to
65944b1
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 24, 2025 21:30 — with
GitHub Actions
Inactive
Added unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the data loader for object with version, and implements the get_past_object (s) APIs.
I used raw string for now but I understand that @emmazzz is already working on porting over
RawSqlQuery
in a separate PR.This is needed in order to implement the more complex get_owned_objects API.
Test plan
We need to add tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.