Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[indexer-alt-jsonrpc] Add basic objects JSONRPC API #20962

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Jan 23, 2025

Description

This PR adds the data loader for object with version, and implements the get_past_object (s) APIs.
I used raw string for now but I understand that @emmazzz is already working on porting over RawSqlQuery in a separate PR.
This is needed in order to implement the more complex get_owned_objects API.

Test plan

We need to add tests.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 9:33pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 9:33pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 9:33pm

Copy link
Contributor

@emmazzz emmazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there plan to add some e2e transactional runner tests to this?

crates/sui-indexer-alt-jsonrpc/src/data/objects.rs Outdated Show resolved Hide resolved
@lxfind
Copy link
Contributor Author

lxfind commented Jan 24, 2025

Is there plan to add some e2e transactional runner tests to this?

We should, but I may not have enough time for this tomorrow.

@lxfind lxfind force-pushed the xun/indexer-alt-json-rpc-objects branch from 7962b99 to 4f73a7b Compare January 24, 2025 01:29
@lxfind lxfind temporarily deployed to sui-typescript-aws-kms-test-env January 24, 2025 01:29 — with GitHub Actions Inactive
@lxfind lxfind force-pushed the xun/indexer-alt-json-rpc-objects branch 2 times, most recently from d6037d9 to 2d19c34 Compare January 24, 2025 21:29
@lxfind lxfind force-pushed the xun/indexer-alt-json-rpc-objects branch from 2d19c34 to 65944b1 Compare January 24, 2025 21:30
@lxfind lxfind temporarily deployed to sui-typescript-aws-kms-test-env January 24, 2025 21:30 — with GitHub Actions Inactive
@lxfind
Copy link
Contributor Author

lxfind commented Jan 24, 2025

Added unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants