Skip to content

Commit

Permalink
Fix audio processing when saving
Browse files Browse the repository at this point in the history
Related to #112

Update the `saveRecording` function in `RecorderEventsHandler.kt` to handle the case where there is only one batch and skip processing.

* Add a check to see if there is only one batch and skip concatenation if true.
* Modify the `saveRecording` function to use the single batch file path if there is only one batch.
* Update the `saveAudioFile` and `saveVideoFile` calls to use the single batch file path if there is only one batch.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Myzel394/Alibi/issues/112?shareId=XXXX-XXXX-XXXX-XXXX).
  • Loading branch information
Myzel394 committed Aug 5, 2024
1 parent 061ed8b commit 9de42e5
Showing 1 changed file with 15 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -176,14 +176,18 @@ fun RecorderEventsHandler(
else -> throw Exception("Unknown recorder type")
}

batchesFolder.concatenate(
recording.recordingStart,
recording.fileExtension,
durationPerBatchInMilliseconds = settings.intervalDuration,
onProgress = { percentage ->
processingProgress = percentage
}
)
val outputFile = if (batchesFolder.getBatchesForFFmpeg().size == 1) {
batchesFolder.getBatchesForFFmpeg().first()
} else {
batchesFolder.concatenate(
recording.recordingStart,
recording.fileExtension,
durationPerBatchInMilliseconds = settings.intervalDuration,
onProgress = { percentage ->
processingProgress = percentage
}
)
}

// Save file
val name = batchesFolder.getName(
Expand All @@ -196,19 +200,13 @@ fun RecorderEventsHandler(
when (batchesFolder) {
is AudioBatchesFolder -> {
saveAudioFile(
batchesFolder.asInternalGetOutputFile(
recording.recordingStart,
recording.fileExtension,
), name
outputFile, name
)
}

is VideoBatchesFolder -> {
saveVideoFile(
batchesFolder.asInternalGetOutputFile(
recording.recordingStart,
recording.fileExtension,
), name
outputFile, name
)
}
}
Expand Down Expand Up @@ -368,4 +366,4 @@ fun RecorderEventsHandler(
showRecorderError = false
},
)
}
}

0 comments on commit 9de42e5

Please sign in to comment.