Fix: Handle Dictionary Responses in jsonfly.lua for Neovim 0.10.1 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntax and version changes not accounted for. Refactored LSP request handling in jsonfly.lua to combine results from multiple LSP responses and handle empty results more gracefully. Improved code readability and maintainability by restructuring the nested if-else blocks.
|
Thank you, unfortunately, I'm not able to reproduce it. I've added some other fixes as well. Once the CI:CD is green we can merge it. Can you then test it again and see if it works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Fix: Handle Dictionary Responses in jsonfly.lua for Neovim 0.10.1
Description:
Fixes error on line 209, where either
response[1]orresponse[1].resultisnil:Cause of the Error
In Neovim 0.10.1, the
vim.lsp.buf_request_allfunction returns a dictionary where the keys are client IDs, and the values are the responses from each client. This is different from earlier versions where the responses were in an array-like table.The current code assumes
response[1]is valid, but in Neovim 0.10.1,responseis a dictionary, so accessingresponse[1]leads tonil.Solution
The callback function has been updated to handle the response correctly by iterating over the dictionary returned by
vim.lsp.buf_request_all, ensuring compatibility with Neovim 0.10.1.