Added a <Delete Me> button to the Contract views (#133) and Provide feedback on contract with no storage (#125) #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issue# 124- Change color of Status Bar based on status of NEO connection
robliou
changed the title
devhawk
reviewed
Jun 2, 2022
| return ( | ||
| <div style={{ padding: 10 }}> | ||
| <h1>{name}</h1> | ||
| <button> Click to Delete </button> |
There was a problem hiding this comment.
Is there logic that gets executed when this button is pushed?
devhawk
reviewed
Jun 2, 2022
|
|
||
| let statement; | ||
|
|
||
| if (name === "StdLib") { |
There was a problem hiding this comment.
CryptoLib doesn't have any storage either
|
If the code isn't completely functional, then lets hold off on the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with issue #133, added a button that can be used to delete contracts (or even chains) that are unused. Note that the button currently isn't functional. I can perhaps add an inline icon later if need be.
Note, however, it is not yet functional. I would like someone's help to write the method to destroy contracts as that is a bit beyond the scope of what I am capable of at this point (unless it entails copying and pasting what is available on the NEO docs website).
Other buttons/functionality that could consider adding to the sidebar would include a smart contract explorer, a governance enabler (voting, candidate registration), wallet functions, data science functions, fees querying, oracle querying, etc.
(Note that the other part of this pull request includes adding a close bracket that was missing from the first pull request I sent earlier).