feat: update pr.yml to use github actor #223
Conversation
Workflow StatusStarting workflow... View action run Collection Publication Status
A PR has been created with the dataset configuration: 🗺️ PR link |
botanical
requested review from
anayeaye,
stephenkilbourn,
slesaad and
amarouane-ABDELHAK
|
I learned about this action that exists after I already implemented my own version of getting the JWT + installation token to authenticate the PR creation https://github.com/actions/create-github-app-token. Does anyone have strong opinions on whether or not we should use the action to create the github app token that GH created? |
.github/workflows/pr.yml
Outdated
| run: | | ||
| echo "${{ env.installation_token }}" | gh auth login --with-token | ||
| git config --global user.name "VEDA-Github-Actor[bot]]" | ||
| git config --global user.email 192275278+VEDA-Github-Actor[bot]@users.noreply.github.com |
There was a problem hiding this comment.
https://api.github.com/users/VEDA-Github-Actor[bot] this is where I got info on the email (I used the ID). I'm not sure if this is something we want to store in an env var?
There was a problem hiding this comment.
I think it makes sense to use an environment variable but this is OK here for now, too
There was a problem hiding this comment.
ca2de70 and variable GH_ACTOR_EMAIL populated as well !
| @@ -293,7 +354,7 @@ jobs: | |||
| body="### Add dataset(s) - $first_collection_id [Automated PR by ${{ github.actor }}]\n\n$collection_bullet_points" | |||
There was a problem hiding this comment.
I left the github.actor here. I think it's nice to see the user that opened the original veda-data PR with the dataset-config changes. Thoughts welcome, though! I'm definitely okay with removing it.
Relevant issue:
#225
Changes
Updated pr.yml workflow to use the GitHub App
VEDA-Github-Actor. You'll notice that the PR it opens will be opened by the GitHub Actor bot and the title of the PR will include the username of the person opening the PR fromveda-dataNASA-IMPACT/veda-config#537Misc
These are the primary documents I referred to in order to implement these changes: