Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test against original cloud chemistry module #9

Open
wants to merge 15 commits into
base: develop-1-review-cloud-chemistry
Choose a base branch
from

Conversation

mattldawson
Copy link
Collaborator

@mattldawson mattldawson commented Feb 5, 2025

Adds a set of tests that run the new cloud chemistry modules (cloud_aqueous_chemistry, cloud_utilities, mam_clouds) with input data collected from running CAM with:

./create_newcase --compset QPC6 --res f10_f10_mg37 --case $CASE_DIR --run-unsupported

There are tests against the output collected from CAM and against the original module code run with the collected inputs.

Closes #4

@mattldawson mattldawson marked this pull request as ready for review February 5, 2025 17:29
Copy link

@boulderdaze boulderdaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have a couple questions.

test/chemistry/cmake/dependencies.cmake Outdated Show resolved Hide resolved
@mattldawson mattldawson requested a review from fvitt February 5, 2025 23:33
@fvitt
Copy link

fvitt commented Feb 6, 2025

@mattldawson
Does this enable the ability to run a stand-alone test outside of CESM/CAM?
Maybe you can explain the need for all the added code the next aerosol dev meeting.

@mattldawson
Copy link
Collaborator Author

@mattldawson Does this enable the ability to run a stand-alone test outside of CESM/CAM? Maybe you can explain the need for all the added code the next aerosol dev meeting.

Hi @fvitt - yes, it does. I added some instructions for running the tests here. This will also allow us to set up a test that ensures the CAM code doesn't diverge from what we put in MICM/CAM-SIMA after we're done refactoring. We can discuss more in the next meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants