Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-dev PR#184 #1073

Merged
merged 53 commits into from
Jun 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
1c6c1d8
Resolve argument mismatch errors when using gfortran
DusanJovic-NOAA Mar 24, 2022
bd588f9
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
DusanJovic-NOAA Apr 8, 2022
f5c5073
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
DusanJovic-NOAA May 13, 2022
a90b957
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
DusanJovic-NOAA Jun 14, 2022
6c87d3e
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
DusanJovic-NOAA Jul 5, 2022
02eb368
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
DusanJovic-NOAA Jul 19, 2022
16ef7f2
Declare variables passed to w3nco library as double precission
DusanJovic-NOAA Jul 19, 2022
696c0ea
More argument mismatch fixes
DusanJovic-NOAA Jul 20, 2022
9da6d0e
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
DusanJovic-NOAA Aug 10, 2022
2686cd1
Merge remote-tracking branch 'origin/main' into no_arg_mismatch
DusanJovic-NOAA Sep 28, 2022
d1e061d
Merge branch 'ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Oct 13, 2022
3302938
Merge branch 'ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Oct 17, 2022
af99a17
Merge branch 'ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Nov 7, 2022
92b8c85
If MPI is used, find package
climbfuji Nov 7, 2022
6c34d5b
Merge branch 'no_arg_mismatch' of https://github.com/DusanJovic-NOAA/…
climbfuji Nov 7, 2022
f943d20
Fixed cmake if/endif mismatch
DusanJovic-NOAA Nov 18, 2022
61e03a8
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Dec 15, 2022
0df1328
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Dec 30, 2022
8c83308
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Mar 16, 2023
347d745
Use mpi_f08 in rrtmgp_lw_main and rrtmgp_sw_main
DusanJovic-NOAA Mar 16, 2023
13c0276
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Mar 29, 2023
a372112
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Apr 26, 2023
a4054ff
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA May 4, 2023
c2763f5
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Jun 8, 2023
b4cb573
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Jun 13, 2023
37fd3fb
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Aug 4, 2023
7307e1a
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Aug 28, 2023
bf68db2
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Sep 15, 2023
53d394d
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Nov 1, 2023
8e52a61
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Nov 3, 2023
360a612
Update GFS_phys_time_vary.fv3.F90 to compile without '-fallow-argumen…
DusanJovic-NOAA Nov 3, 2023
ce64f1a
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Dec 18, 2023
c2f80ab
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Jan 4, 2024
531cd86
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Jan 16, 2024
47d4bff
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Feb 7, 2024
bac1994
Change the type of mpi communicator in few more files
DusanJovic-NOAA Feb 7, 2024
8c68c2f
Fix mpi use statement
DusanJovic-NOAA Feb 7, 2024
dbef1a7
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Feb 26, 2024
bb9b90f
Update MPI find_package and check if MPI F08 module is supported
DusanJovic-NOAA Feb 26, 2024
0cb5d97
Remove C from MPI find_package
DusanJovic-NOAA Feb 27, 2024
e1db7f2
In physics/Interstitials/UFS_SCM_NEPTUNE/maximum_hourly_diagnostics.m…
climbfuji Mar 8, 2024
26f9514
In physics/Interstitials/UFS_SCM_NEPTUNE/maximum_hourly_diagnostics.F…
climbfuji Mar 8, 2024
743dc85
correctly convert from flashes per five minutes to flashes per minute
SamuelTrahanNOAA Mar 11, 2024
7e74ada
correct the meta file
SamuelTrahanNOAA Mar 11, 2024
c97a968
Merge pull request #16 from SamuelTrahanNOAA/dom-flash-correctly
climbfuji Mar 11, 2024
1497772
Introduce namelist flag to convection/cloud/radiation interaction in …
lisa-bengtsson Mar 12, 2024
8dff959
Merge pull request #181 from grantfirl/csawv2_gjf
grantfirl Mar 14, 2024
2f15ae9
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
climbfuji Mar 14, 2024
9f4a96b
Merge pull request #182 from climbfuji/feature/fix_units_flashes_per_…
grantfirl Mar 18, 2024
94596b3
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
DusanJovic-NOAA Mar 18, 2024
9839680
Merge pull request #160 from DusanJovic-NOAA/no_arg_mismatch
dustinswales Mar 19, 2024
7fa5593
Merge branch 'ufs/dev' of https://github.com/ufs-community/ccpp-physi…
lisa-bengtsson Mar 19, 2024
a3760b8
Merge branch 'cloudPR' into ufs-dev-PR184
grantfirl May 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin/ufs/dev' into no_arg_mismatch
  • Loading branch information
DusanJovic-NOAA committed Aug 4, 2023
commit 37fd3fb6cdd95925d09971f8a83834cd23c36154
35 changes: 28 additions & 7 deletions physics/aerinterp.F90
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,8 @@ subroutine read_netfaer(nf, iflip,nt, errmsg,errflg)
use aerclm_def
use netcdf
integer, intent(in) :: iflip, nf, nt
integer :: ncerr
integer, intent(inout) :: errflg
character(*), intent(inout) :: errmsg
integer :: ncid, varid, i,j,k,ii,klev
character :: fname*50, mn*2, vname*10
real(kind=kind_io4),allocatable,dimension(:,:,:) :: buff
Expand All @@ -458,11 +459,22 @@ subroutine read_netfaer(nf, iflip,nt, errmsg,errflg)

write(mn,'(i2.2)') nf
fname=trim("aeroclim.m"//mn//".nc")
ncerr = nf90_open(fname , NF90_NOWRITE, ncid)
ncid = -1
if(.not.netcdf_check(nf90_open(fname , nf90_NOWRITE, ncid), &
errmsg, errflg, 'open '//trim(fname))) then
return
endif

! ====> construct 3-d pressure array (Pa)
ncerr = nf90_inq_varid(ncid, "DELP", varid)
ncerr = nf90_get_var(ncid, varid, buff)
varid = -1
if(.not.netcdf_check(nf90_inq_varid(ncid, "DELP", varid), &
errmsg, errflg, 'find id of DELP var')) then
return
endif
if(.not.netcdf_check(nf90_get_var(ncid, varid, buff), &
errmsg, errflg, 'read DELP var')) then
return
endif

do j = jamin, jamax
do i = iamin, iamax
Expand Down Expand Up @@ -491,8 +503,15 @@ subroutine read_netfaer(nf, iflip,nt, errmsg,errflg)
! for GFS, iflip 0: toa to sfc; 1: sfc to toa
DO ii = 1, ntrcaerm
vname=trim(specname(ii))
ncerr = nf90_inq_varid(ncid, vname, varid)
ncerr = nf90_get_var(ncid, varid, buffx)
varid = -1
if(.not.netcdf_check(nf90_inq_varid(ncid, vname, varid), &
errmsg, errflg, 'get id of '//trim(vname)//' var')) then
return
endif
if(.not.netcdf_check(nf90_get_var(ncid, varid, buffx), &
errmsg, errflg, 'read '//trim(vname)//' var')) then
return
endif

do j = jamin, jamax
do k = 1, levsaer
Expand All @@ -514,7 +533,9 @@ subroutine read_netfaer(nf, iflip,nt, errmsg,errflg)
ENDDO ! ii-loop (ntracaerm)

! close the file
ncerr = nf90_close(ncid)
if(.not.netcdf_check(nf90_close(ncid), errmsg, errflg, 'close '//trim(fname))) then
return
endif
deallocate (buff, pres_tmp)
deallocate (buffx)
END SUBROUTINE read_netfaer
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.