UFS-dev PR#223 #1095
Merged
UFS-dev PR#223 #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/gfs_debug_update
… into feature/gfs_debug_update
… into feature/gfs_debug_update
… into feature/gfs_debug_update
…/CLM/clm_lake.f90 and remove OPTIONAL keyword from Fortran code to fix intel 19 runtime issues
… into feature/gfs_debug_update
… into feature/refactor_h2ophys
Land surface upgrades for HR4
Convert GFS DDTs from blocked data structures to contiguous arrays (aka update GFS_debug.F90)
grantfirl
requested review from
Qingfu-Liu,
dustinswales and
barlage
as code owners
grantfirl
requested review from
RuiyuSun,
AndersJensen-NOAA,
lisa-bengtsson and
mzhangw
as code owners
grantfirl
requested review from
mkavulich,
rhaesung and
climbfuji
and removed request for
barlage,
joeolson42,
mzhangw,
gthompsnWRF,
tanyasmirnova,
SamuelTrahanNOAA,
RuiyuSun,
cenlinhe,
JongilHan66,
lisa-bengtsson and
AndersJensen-NOAA
Understood. I can re-request reviews as previous ones get merged to make this easier to review. I understand that it is difficult to review them as they are "stacked" on top of each other. It's just easier for me to do it this way. |
dustinswales
approved these changes
Oct 22, 2024
rhaesung
approved these changes
Oct 22, 2024
|
@climbfuji This PR has been updated and should only contain changes from ufs-community#223 |
climbfuji
approved these changes
Oct 22, 2024
| if (allocated(h2o_lat) ) deallocate(h2o_lat) | ||
| if (allocated(h2o_pres)) deallocate(h2o_pres) | ||
| if (allocated(h2o_time)) deallocate(h2o_time) | ||
| if (allocated(h2oplin) ) deallocate(h2oplin) |
There was a problem hiding this comment.
yay! Stateless CCPP :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to ufs-community#223
Note: One small typo fixed in GFS_phys_time_vary.scm.F90