Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return MICM solver state details from MicmSolve() #145

Merged
merged 115 commits into from
Jun 24, 2024
Merged

Return MICM solver state details from MicmSolve() #145

merged 115 commits into from
Jun 24, 2024

Conversation

boulderdaze
Copy link
Collaborator

@boulderdaze boulderdaze commented Jun 12, 2024 •
edited
Loading

Closes #83

boulderdaze and others added 30 commits May 23, 2024 16:12
@boulderdaze
test adding clang tidy
4141b8b
@boulderdaze
add header filter
2898dc0
@boulderdaze
add clang tidy
e5d1ba8
@boulderdaze
test exclude header
d12ba99
@boulderdaze
fix typo
1407c7d
@boulderdaze
test with continue on
eed79aa
@boulderdaze
remove exclude header
49894ae
@boulderdaze
fix a bug
7fc87c4
@boulderdaze
change the branch name
e9c7ee6
@boulderdaze
revert back
0f9d32d
@K20shores
strating the grids data types and functions
7af747e
@K20shores
starting to rough out the apis
9d3d031
@boulderdaze
clang tidy
38c438f
@boulderdaze
Merge branch 'main' into 128-clang-tidy
4de4be9
@boulderdaze
Merge branch 'main' into 128-clang-tidy
915360f
@boulderdaze
fix python bug
4eeb639
@K20shores
some changes
57a725e
@K20shores
calling interanl function
1f533e9
@K20shores
need to resolve error handling in both tuvx and micm
73f411c
@K20shores
trying to figure out why there's an error
93304ed
@K20shores
removing nullptr argument on tuvx
7da894c
@K20shores
it compiles, one test fails
8ea9e3b
@K20shores
disabling bad configuration test until tuvx is fixed
b15d7b9
@boulderdaze
Merge branch 'main' into 128-clang-tidy
ddc50a6
@boulderdaze
fix C function name
5666b54
@K20shores
grid warehouse pointer now in fortran
1eb28d5
@K20shores
addig comments
a48047e
@K20shores
saving progress
b7e001b
@K20shores
merging
1c099f5
@boulderdaze
fix memcheck failure
468a6ba
@boulderdaze boulderdaze marked this pull request as ready for review June 21, 2024 22:25
K20shores
K20shores approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@K20shores K20shores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

mattldawson
mattldawson approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

dwfncar
dwfncar approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@dwfncar dwfncar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@boulderdaze boulderdaze merged commit 2a3b32e into main Jun 24, 2024
36 checks passed
@boulderdaze boulderdaze deleted the 83-solver-result branch June 24, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K20shores K20shores K20shores approved these changes

@mattldawson mattldawson mattldawson approved these changes

@dwfncar dwfncar dwfncar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return MICM solver state details from micm_solve()
4 participants
@boulderdaze @dwfncar @mattldawson @K20shores