Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing and CI tidying including adding Python 3.12 job #703

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

sadielbartholomew
Copy link
Member

Minor admin tweaks to:

  • add some missing newer Python versions into the CI test workflow, including support for the new latest major version 3.12, which was released about 3 weeks ago which I tested locally to be compatible dependency-wise with cf and that all tests pass as they should with it (:heavy_check_mark:);
  • add some test method skips where SciPy is required under-the-hood but not directly in the test, which produces a somewhat confusing error message as an outcome of NameError: name 'convolve1d' is not defined. Did you mean: 'cf_convolve1d'? because it can't find the scipy convolve1d and suggests our own wrapper;
  • make two small formatting tweaks so that test_style i.e. pycodestyle passes.

@sadielbartholomew sadielbartholomew added code tidy CI testing Issues related to units tests and their coverage GitHub Actions Anything relating to GitHub actions labels Oct 24, 2023
Copy link
Collaborator

@davidhassell davidhassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sadie - all these changes look very good to me. Please merge.

@davidhassell davidhassell added this to the Next release milestone Oct 25, 2023
@sadielbartholomew sadielbartholomew merged commit 2d53ef6 into NCAS-CMS:main Oct 25, 2023
2 of 3 checks passed
@sadielbartholomew sadielbartholomew deleted the drop-python-3.7 branch October 25, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI code tidy GitHub Actions Anything relating to GitHub actions testing Issues related to units tests and their coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants