Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in cf.Field.subspace and cf.Field.__getitem__ for some cyclic subspaces #714

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix bug in cf.Field.subspace and cf.Field.__getitem__ for some cyclic subspaces #714

merged 1 commit into from
Feb 20, 2024

Conversation

davidhassell
Copy link
Collaborator

Fixes #713

@davidhassell davidhassell added this to the 3.17.0 milestone Feb 19, 2024
@davidhassell davidhassell added the bug Something isn't working label Feb 19, 2024
sadielbartholomew
sadielbartholomew approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. Fixes the bug and captures it in a test; excellent, please merge.

@davidhassell davidhassell merged commit 253e21d into NCAS-CMS:main Feb 20, 2024
2 of 4 checks passed
@davidhassell davidhassell deleted the cyclic-subspace branch February 20, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.16.1
Development

Successfully merging this pull request may close these issues.

Bug in cf.Field.subspace and cf.Field.__getitem__ for some cyclic subspaces
2 participants
@davidhassell @sadielbartholomew