Correct finding coordrefs in cf.aggregate
#783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi David, were you wanting a review on this - not sure since it's open not as a draft and seems ready but I've not been assigned, so thought I'd check? |
sadielbartholomew
approved these changes
Jun 12, 2024
|
Got any ideas of what it could say (I haven't :)) |
You make a good point, I do not 😆 Therefore, leaving this out from the changelog only makes sense - as you imply, the bug this fixes could only manifest for users if they are doing something really quite strange, so is unlikely. So, all good - please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit tricky to test, as I can't see a case where the bug isn't benign: If two fields have different coordinate references, then they won't get aggregated anyway, regardless of whether or not any coordinate references are attached to dimension coordinates (which is the "bug")