Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure when creating 'T: mean within days time: minimum over days'' collapse #810

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Fix failure when creating 'T: mean within days time: minimum over days'' collapse #810

merged 4 commits into from
Sep 10, 2024

Conversation

davidhassell
Copy link
Collaborator

Fixes #809

@davidhassell davidhassell added the bug Something isn't working label Sep 2, 2024
@davidhassell davidhassell added this to the NEXT VERSION milestone Sep 2, 2024
sadielbartholomew
sadielbartholomew reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One changelog fix to make, otherwise as discussed in person this is all good but I'll wait on that clarifying comment you are going to add before giving final reviewer approval. Thanks.

Changelog.rst Outdated Show resolved Hide resolved
@davidhassell
Copy link
Collaborator Author

Thanks, Sadie - here's the comment: 98241d2

sadielbartholomew
sadielbartholomew approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding some clarification. All good to go!

@davidhassell davidhassell merged commit 39136ff into NCAS-CMS:main Sep 10, 2024
@davidhassell davidhassell deleted the timeduration-mod branch September 10, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
NEXT VERSION
Development

Successfully merging this pull request may close these issues.

Failure when creating 'T: mean within days time: minimum over days'' collapse
2 participants
@davidhassell @sadielbartholomew