-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new recipe (17) by summer student: colourmap subplots #819
Add new recipe (17) by summer student: colourmap subplots #819
Conversation
Thank you for this submission, and please extend thanks to Natalia as well. The output plot looks fantastic! Having the perceptually uniform colour maps, NCL enhanced colour maps, and orography/bathymetry colour maps in separate columns clearly demonstrates their distinct characteristics and helps users quickly understand how each type can affect data representation. The use of orography/bathymetry colour scales with air temperature data is a good example of how certain colour maps may not be suitable for certain datasets, as the comments explain. The overall visual output looks great, and once the remaining files are updated and generated (see my review #818 (comment) of the first recipe), this PR should be good to go. Excellent work on making this visually informative and accessible! |
Thanks again for your review, @bewithankit. See my latest comment on #818 as to my suggestion for getting these summer student recipe PRs (including the three I will put up in the next few days to complete the set, too) merged. I have updated this PR to add to the |
Given how busy Ankit is with his PhD we have agreed I can merge this without second review. At release time I will enact the plan I outlined above:
So, merging, and there will eventually be a follow-on PR to get all the new recipes built and included. |
This is the first of three recipes created this summer by our first summer student of two, Natalia, at least from the first commit - I have updated it somewhat to show mutliple colour scale categories as sub-plot columns, instead of having each category available from commenting out different parts of the data, which seems more in line with the form of our recipes.
It has been prepared in the form consistent with the existing recipes. Should be nature be self-explanatory. See my comment for the first recipe, #818, for context.
Expected output