New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing post_processing errors to fail more gently #476

Merged

MarkDWilliams merged 1 commit into master from appraiserFailGently

Aug 15, 2023

Collaborator

MarkDWilliams commented Aug 15, 2023

No description provided.


          Allowing post_processing errors to fail more gently

7cacd87

Collaborator Author

MarkDWilliams commented Aug 15, 2023

This should address two instance which were giving us trouble in post_processing

Node Annotator returns a NoneType as one of the attributes for a node
When Appraiser fails (in the test case, due to a 422 being returned because of critical TRAPI errors in returns from an ARA), the default ordering_components are now only imposed on Results that didn't have them already. This preserves the ordering_components from merges that did not have appraiser issues and thus, the ability to score them as well.

MarkDWilliams requested a review from ShervinAbd92

August 15, 2023 18:30

ShervinAbd92 approved these changes

View reviewed changes

MarkDWilliams merged commit e585e23 into master

MarkDWilliams deleted the appraiserFailGently branch

August 15, 2023 18:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet