Fix linked RFP labels for 0 id (#901)

* fix linked RFP labels for 0 id * fix tests * fix test
NEAR-DevHub · Jul 24, 2024 · d858185 · d858185
1 parent fbac81e
commit d858185
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/instances/infrastructure-committee.near/widget/components/proposals/Editor.jsx b/instances/infrastructure-committee.near/widget/components/proposals/Editor.jsx
@@ -785,7 +785,10 @@ const onSubmit = ({ isDraft, isCancel }) => {
         },
   };
   const args = {
-    labels: linkedRfp ? [] : (labels ?? []).map((i) => i.value ?? i),
+    labels:
+      typeof linkedRfp === "number"
+        ? []
+        : (labels ?? []).map((i) => i.value ?? i),
     body: body,
   };
   if (isEditPage) {

diff --git a/instances/infrastructure-committee.near/widget/components/proposals/Proposal.jsx b/instances/infrastructure-committee.near/widget/components/proposals/Proposal.jsx
@@ -523,7 +523,7 @@ const editProposal = ({ timeline }) => {
     supervisor: supervisor ?? snapshot.supervisor,
   };
   const args = {
-    labels: snapshot.linked_rfp ? [] : snapshot.labels,
+    labels: typeof snapshot.linked_rfp === "number" ? [] : snapshot.labels,
     body: body,
     id: proposal.id,
   };

diff --git a/playwright-tests/tests/infrastructure/proposal.spec.js b/playwright-tests/tests/infrastructure/proposal.spec.js
@@ -62,7 +62,7 @@ test.describe("Wallet is connected as admin", () => {
     await expect(transactionText).toEqual(
       JSON.stringify(
         {
-          labels: [],
+          labels: ["Other"],
           body: {
             proposal_body_version: "V1",
             linked_rfp: 0,
@@ -137,7 +137,7 @@ test.describe("Wallet is connected as admin", () => {
       "hemera.near", // author,
       "infrastructure-committee.near", //  requested_sponsor,
       "trechriron71.near", // comment author,
-      "root.near",
+      "as2.near",
     ];
     let mentionSuggestions = [];
     for (let i = 0; i < liLocators.length; i++) {