-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse PostEditor instead of Create component #615
Reuse PostEditor instead of Create component #615
Conversation
Redirection on Approval/Rejection of txn works only on @petersalomonsen preview, since it invalidates the cache which cause rerendering |
Since we can't redirect user without their explicit action in BOS, so I did this instead. Video.mov |
Hi @Megha-Dev-19 – It this UX going to apply to all users? Or just ones who use MNW? Can you also share the current state that you're trying to fix with this solution? |
Hey @ori-near, this UX will be applied to all users (once Peter's PR is merged), but until then only to those who use his MNV. Currently this is how it is handled:
Screen.Recording.2024-01-03.at.14.08.15.mov
Video.1.mov
Video.2.movbut with current changes, edit/reply post will be like this (irrespective of if user has allowed the function calls) : Screen.Recording.2024-01-03.at.14.20.05.mov |
Hi @Megha-Dev-19 – thank you so much for clarifying. As we discussed, I think this solution looks good. However, if there is a way to redirect the user to the actual post that would be even better. CC: @petersalomonsen |
In order to redirect the user to the latest created post, we need the result of the create transaction, which should return the post_id. To get results from a transaction, we depend on this: NearSocial/VM#105 |
hey @Tguntenaar @elliotBraem, can you please review the PR.? |
hey @ori-near, as we discussed yesterday, I can't scroll to the top or the edited post, since we don't have access to |
Resolves #538
Resolves #555
Resolves #591
Resolves #590
Resolves #547
Preview link