Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infrastructure-committee #857

Merged

Conversation

Megha-Dev-19
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 commented Jun 26, 2024

  • Fix tests
  • Add script to deploy to infrastructure account (dry run: there will be changes in dry-run since earlier we use to import common.jsx instead of replacements)
  • Thoroughly test the frontend manually

Need to add following keys to github vars:

  • NEAR_INFRA_SOCIAL_ACCOUNT_ID
  • NEAR_INFRA_SOCIAL_ACCOUNT_PUBLIC_KEY
  • NEAR_INFRA_SOCIAL_ACCOUNT_PRIVATE_KEY
  • NEAR_INFRA_SOCIAL_DEPLOY_ID

Megha-Dev-19 and others added 30 commits December 7, 2023 15:42
@petersalomonsen
Copy link
Collaborator

So as we discussed in the call, we will need:

  • A separate copy of the CI workflow targeting the infrastructure committee instance ( running the tests that are relevant )
  • A deployment action that does diff ( dry-run ) when not on the main branch
  • We also need to include the infrastructure committee test folder in the CI workflow for Infrastructure committee

@petersalomonsen petersalomonsen self-requested a review July 7, 2024 14:41
@Megha-Dev-19 Megha-Dev-19 marked this pull request as ready for review July 8, 2024 21:19
@Megha-Dev-19 Megha-Dev-19 requested a review from Tguntenaar as a code owner July 8, 2024 21:19
Copy link
Collaborator

@petersalomonsen petersalomonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Megha-Dev-19 , only minor comments from me

The cancel RFP test is reported as flaky in the test run. Any chance to investigate that to reduce introduction of more flaky tests?

Also there's the blog fix for variables in styled divs in the main branch, so it would be good to run the test suite on top of that as well.

@Megha-Dev-19 Megha-Dev-19 merged commit bd8dbd0 into NEAR-DevHub:main Jul 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants