Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/885 relevant users events portals #886

Merged

Conversation

Tguntenaar
Copy link
Collaborator

@Tguntenaar Tguntenaar commented Jul 19, 2024

Resolves #885

Adds the changes made to devhub portal in PR 845 to the events-committee.

video.webm

@Tguntenaar Tguntenaar requested a review from Megha-Dev-19 as a code owner July 19, 2024 10:27
@Tguntenaar
Copy link
Collaborator Author

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Jul 19, 2024

@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Are you going to win race-of-sloths this month? If so, you should speed up! Run, Sloth, run!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@Megha-Dev-19 2

The average score is 2

@Tguntenaar check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Comment on lines 141 to 147
let limit = 5;
if (term.length < 2) {
results = [${sortedRelevantUsers
.map((u) => "{accountId:'" + u + "', score: 60}")
.join(",")}];
limit = ${5 + sortedRelevantUsers.length};
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we use reuse SimpleMDE from the devhub instance?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes defenitly, we can do it in the next iteration of improvements.

Comment on lines 3 to 6
"accounts": {
"deploy": "events-committee.near",
"signer": "events-committee.near"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

@Megha-Dev-19
Copy link
Collaborator

@race-of-sloths score 2

@race-of-sloths
Copy link

🌟 Score recorded!

@Megha-Dev-19, thank you for scoring this pull request in the Race of Sloths!

@Tguntenaar Tguntenaar merged commit 724cbcd into NEAR-DevHub:main Jul 25, 2024
15 checks passed
@race-of-sloths
Copy link

✅ PR is finalized!

Your contribution is much appreciated with a final score of 2!
You have received 20 Sloth points for this contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add relevant users to events / infrastructure commitee
3 participants