fix that submit draft keeps on spinning

[petersalomonsen]

Based on the report that some user only saw the submit button spinner keeping on spinning, which I assume is as reproduced in the test that can be seen in the video here:

create-proposal-spinner-without-fix.mp4

The test reproduces a scenario where the transaction completes, but the view call for getting all proposal ids does not show the latest proposal immediately, which might happen in the case the transaction is not fully finalized. The previous implementation will then just keep on spinning, and so it is assumed that this is what the user experienced.

By retrying checking for the latest proposal until it matches the submitted title and description, the submitted proposal will be found eventually, and the submit button will stop spinning, and the new proposal should display.

With the fix, the submit button stops spinning, and the submitted proposal is displayed:

create-proposal-spinner-fix.mp4

[petersalomonsen]

@race-of-sloths include

[race-of-sloths-bot]

@petersalomonsen Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Current status: waiting for finalization

The pull request is merged, you have 24 hours to finalize your scoring. The scoring ends Tue Oct 8 19:40:46 2024

Reviewer	Score
@Megha-Dev-19	3

Your contribution is much appreciated with a final score of 3!
You have received 30 Sloth points for this contribution

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

• Tag @race-of-sloths inside your pull requests
• Wait for the maintainer to review and score your pull request
• Check out your position in the Leaderboard
• Keep weekly and monthly streaks to reach higher positions
• Boast your contributions with a dynamic picture of your Profile

For maintainers:

• Score pull requests that participate in the Race of Sloths
• Engage contributors with fair scoring and fast responses so they keep their streaks
• Promote the Race to the point where the Race starts promoting you
• Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

• For contributors
  • Include a PR: @race-of-sloths include to enter the Race with your PR
• For maintainers:
  • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
  • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
  • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
  • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

[trechriron]

Love this!

[Megha-Dev-19]

LGTM
I think we need to make this change to RFP as well in infra.

[Megha-Dev-19]

@race-of-sloths score 3

[race-of-sloths]

@petersalomonsen Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
King of Sloths shakes your hand! Yellow leader's jersey is yours deservedly!

Current status: executed

Reviewer	Score
@Megha-Dev-19	3

Your contribution is much appreciated with a final score of 3!
You have received 53 (30 base + 20 weekly bonus + 5% lifetime bonus) Sloth points for this contribution

Another weekly streak completed, well done @petersalomonsen! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

• Tag @race-of-sloths inside your pull requests
• Wait for the maintainer to review and score your pull request
• Check out your position in the Leaderboard
• Keep weekly and monthly streaks to reach higher positions
• Boast your contributions with a dynamic picture of your Profile

For maintainers:

• Score pull requests that participate in the Race of Sloths
• Engage contributors with fair scoring and fast responses so they keep their streaks
• Promote the Race to the point where the Race starts promoting you
• Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

• For contributors
  • Include a PR: @race-of-sloths include to enter the Race with your PR
• For maintainers:
  • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
  • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
  • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
  • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called