-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades to react-router 6.4 #6
Conversation
How can we test this @elliotBraem ? Maybe the time has come to introduce Playwright, so that we also can generate videos for PR reviews? Would be great to easily show a video demo of the enhancement here, in addition to that everything works as before with the upgrade of react router. |
I think that's a great idea -- but what do you mean by generating videos? Does playwright have this feature? I'm actually getting testing started for potlock rn, just opened this PR: PotLock/bos-app#488 I'm glad you brought this up, because it highlights a few things I've been trying to understand. Also, I've noticed that bos-workspace can replace the scripts/dev-gateway from devhub repo, we can also specify dist to use with -g flag. |
Yes it is a simple boolean flag in the playwright config. Just see the videos in here: NEAR-DevHub/neardevhub-bos#691 (comment)
That is awesome! Happy to see more testing for projects in the ecosystem. I think this makes it so much easier to demonstrate and document pull requests, and also reduce the fear of breaking things.
That's nice ! Can you develop with this without having to use localstorage flags for the bos-loader? you maybe don't need the bos-loader at all when using bos-workspace? |
Added tests @petersalomonsen Default w/ intitialProps: Other paths w/ params: |
This upgrades react-router-dom to 6.4 and migrates usage. Looks like this now:
Is also solves an issue I realized from previous PR that provided paths were not being supported outside default widget. Now you can do something like this again:
http://127.0.0.1:3000/efiz.near/widget/Tree
; previously it would still only show default widget.