Feature/ed 46 api vscode #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests all working still and deploymentGenerator.spec.js test extended to include vscode manifest creation test
…hat was proven to run the pod
…tations for axios and graphql
In a test environment this completes the addition of vscode, although there are issues with websockets which breaks some of the functionality. We update all the image_config.json files to include the vscode additions, so local development and the frontend see the new notebook type. Since the token acquisition in stackUrlService.js is identical to Jupyter notebooks we refactor it into a generic function. Use of the logo should comply with the restrictions given at https://code.visualstudio.com/brand. Jira: ED-45 Jira: ED-46
iwalmsley
requested changes
Nov 23, 2023
code/workspaces/infrastructure-api/resources/vscode.deployment.template.yml
Outdated
Show resolved
Hide resolved
code/workspaces/infrastructure-api/resources/vscode.deployment.template.yml
Outdated
Show resolved
Hide resolved
iwalmsley
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds VS Code as a Notebook environment.
Key features: