Corrected link to 'how-to' docs for rstudio notebook warning message #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshholland
approved these changes
Apr 4, 2024
| @@ -179,7 +182,7 @@ const StackCard = ({ classes, stack, openStack, deleteStack, editStack, restartS | |||
| /> | |||
| </div> | |||
| </div> | |||
| {NOTEBOOK_TYPE_NAME === typeName && warningMessage && <SuspendWarning message={warningMessage} />} | |||
| {NOTEBOOK_TYPE_NAME === typeName && warning.message && <SuspendWarning message={warning.message} docId={warning.docId}/>} | |||
There was a problem hiding this comment.
Could use spread syntax to pass the props here:
<SuspendWarning {...warning}/>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an rstudio notebook has recently been opened, a warning message is displayed when viewing notebooks in a project to alert the user to potentially interrupting the current user's access. This message has a link on the 'more' button pointing to a docs page explaining more about it. But the link was pointing to the wrong how-to doc, which (as you'll see when you review it) is because it was implemented as a change to the SuspendWarning component and only the message had been made dynamic, not the link.
This pull request corrects it.