Add a dockerfile and lines in the README #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metazool
requested review from
jmarshrossney and
albags
and removed request for
jmarshrossney
|
I'm just passing these through at the moment - documentation wrap-up - but added you as reviewers @jmarshrossney and @albags to keep you in the loop with changes (and as a reference point for the basic container build) |
albags
reviewed
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Dockerfile to run the API in a container, following the pattern here:
https://fastapi.tiangolo.com/deployment/docker/
Adds a couple of lines in the README for building with
dockerorpodmanLinked to this issue about running the API for managing plankton imagery