-
Notifications
You must be signed in to change notification settings - Fork 223
Add gitignores for Visual Studio Code #512
base: dev
Are you sure you want to change the base?
Conversation
From GitHub official repository (see repo github/gitignore/Global/VisualStudioCode.gitignore)
👍 |
Just out of curiosity, why the .json files needs to be present in the repo? I am not against the change, I have already excluded .vscode/ in my branch, but I certainly have different settings.json and I don't use Code debugger (so no launch.json). These are user-specific files... |
@cw2 great question... as I've mentioned: I took that from the official repo. Didn't gave it much thought, I admit. I guess that's the way to save the user's preferences and settings back to the repo. Actually I don't think this is of use to NETMF in particular so those 3 lines can be there or not. |
User specific settings should be ignored in the repo. However VS code (and .NET CORE) have used .json files as the project file format - though from what I have read they are moving away from that as it has not been a positive experience. |
@@ -31,6 +31,12 @@ | |||
ipch/ | |||
*.VC.db | |||
|
|||
# Visual Studio Code | |||
.vscode/* | |||
!.vscode/settings.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mis-read this earlier, let's not be including these in the tree as the VSCode system is still in flux and not officially supported (e.g. just block all of the .vscode folder and leave it at that. Otherwise people are forced to use VSCode to ensure the JSON files are updated correctly when making changes even if they don't otherwise use VSCode. By allowing them into the tree we effectively make them officially part of NETMF and they must then be maintained tested and validated for each PR etc...
From GitHub official repository (see repo github/gitignore/Global/VisualStudioCode.gitignore)