This repository has been archived by the owner on Jun 5, 2019. It is now read-only.
Fix #212 - Hovering over Vb globals crashes VS #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Issue NETMF#212 where VS crashes when hovering over a global var in a vb module. The fix here is to make sure that CorDebugClass responds correctly to calls to CorDebugClass.GetParameterizedType. Originally it should have returned E_NOTIMPL, but it returned OK and a null which is what causes the crash. This function is supposed to return full specified types derived from generic classes and wasn't implemented because netmf doesn't do generics, but it also gets called for classes with no specialization types when trying to create a type enclosure for Vb globals. Now, with this change, it returns a properly specialized type definition. The constructor had to be specialized to accommodate the fact debugger values known the appdomain, and type specializations need an assembly and type domain.
martincalsyn
commented
Sep 20, 2018
| @@ -122,7 +122,7 @@ public uint TypeDef_Index | |||
| int ICorDebugClass2.GetParameterizedType( CorElementType elementType, uint nTypeArgs, ICorDebugType []ppTypeArgs, out ICorDebugType ppType ) | |||
| { | |||
| // CorDebugClass.GetParameterizedType is not implemented | |||
There was a problem hiding this comment.
Technically, I guess this comment isn't true anymore. It is implemented, but only works for non-generic types (which is the only kind of type that ever gets requested)
josesimoes
added a commit
to Eclo/nf-Visual-Studio-extension
that referenced
this pull request
Sep 21, 2018
- Add proper implementation for GetStaticFieldValue and GetParameterizedType (from NETMF/netmf-interpreter#552) - Tidy code Signed-off-by: José Simões <[email protected]>
10 tasks
josesimoes
added a commit
to Eclo/nf-Visual-Studio-extension
that referenced
this pull request
Sep 21, 2018
- Add proper implementation for GetStaticFieldValue and GetParameterizedType (from NETMF/netmf-interpreter#552) - Tidy code Signed-off-by: José Simões <[email protected]>
josesimoes
added a commit
to Eclo/nf-Visual-Studio-extension
that referenced
this pull request
Sep 21, 2018
- Add proper implementation for GetStaticFieldValue and GetParameterizedType (from NETMF/netmf-interpreter#552) - Tidy code Signed-off-by: José Simões <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Issue #212 where VS crashes when hovering over a global var in a vb module.
The fix here is to make sure that CorDebugClass responds correctly to calls to CorDebugClass.GetParameterizedType. Originally it should have returned E_NOTIMPL, but it returned OK and a null which is what causes the crash. This function is supposed to return full specified types derived from generic classes and wasn't implemented because netmf doesn't do generics, but it also gets called for classes with no specialization types when trying to create a type enclosure for Vb globals.
Now, with this change, it returns a properly specialized type definition. The constructor had to be specialized to accommodate the fact debugger values known the appdomain, and type specializations need an assembly and type domain.