Replace upper default boundary for percentage with infinity instead o… #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martialblog
reviewed
Jun 3, 2024
| @@ -564,7 +564,7 @@ func init() { | |||
| IsSet: true, | |||
| Th: check.Threshold{ | |||
| Lower: 2, | |||
| Upper: 100, | |||
There was a problem hiding this comment.
Can you add a bit more context on why? Intuitively I would have said a percentage - having a Latin "per cento" origin meaning "from 100" - would have 100 as upper.
There was a problem hiding this comment.
That is indeed true and was my original thought here. The problem is, that some Monitoring systems (Icinga) chose to ignore the standard and are unable to parse the range format (2:100), so I replaced that here with infinity which results in the range of 2: which can be parsed and is functionally equivalent.
Tl:dr: It's a hack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f 100