-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Spear.append/3
raw?: true
raw return
#97
Merged
the-mikedavis
merged 7 commits into
NFIBrokerage:main
from
byu:fix-append-raw-true-result
May 9, 2024
Merged
fix: Spear.append/3
raw?: true
raw return
#97
the-mikedavis
merged 7 commits into
NFIBrokerage:main
from
byu:fix-append-raw-true-result
May 9, 2024
Commits on May 2, 2024
-
fix:
Spear.append/3
raw?: true
raw returnIssue NFIBrokerage#96 Passing a `raw?: true` option to `Spear.append/3` or `Spear.Client/append` continued to return `:ok` instead of `{:ok, AppendResp.t()}`. This contradicted the docs and the `Spear.append_batch/5` behaviour. Solution: This commit adds the conditional case in `Spear.append/3` to return `{:ok, AppendResp.t()}` when `raw?` is `true`. `Spear.Client.append` will also be fixed as a result. Additional Notes: * Added to `SpearTest`: to test `append/3` for both raw true and false * Added to `SpearTest`: to test `append_batch/5` for both raw true and false. * Updated the `Spear.append/3` type spec to add the missing `{:ok, AppendResp.t()}` return type. * Updated the `Spear.Client.append/3` and `Spear.Client.append/4` callback specs to add the missing `{:ok, AppendResp.t()}` return type.
Configuration menu - View commit details
-
Copy full SHA for 77dabbb - Browse repository at this point
Copy the full SHA 77dabbbView commit details
Commits on May 3, 2024
-
fix: append_batch raw test, add compat tag
adding compat tag to the append_batch tests, which weren't carried over from the append_batch test copy pasting.
Configuration menu - View commit details
-
Copy full SHA for 168ba91 - Browse repository at this point
Copy the full SHA 168ba91View commit details -
Fixes a `mix format --check-formatted` issue in `spear_test.exs` that was caught with Elixir 1.14, vs not catching in Elixir 1.16.2.
Configuration menu - View commit details
-
Copy full SHA for f86a938 - Browse repository at this point
Copy the full SHA f86a938View commit details
Commits on May 6, 2024
-
fix:
Spear.append
raw?: returns full AppendRespBefore, it was pulling out the "result", now we're returning the raw proto
Configuration menu - View commit details
-
Copy full SHA for a1038cc - Browse repository at this point
Copy the full SHA a1038ccView commit details -
1. fixes the unintentionally added extra nesting of `{:ok, {:ok, resp}}` Instead, when success and raw flag set, returns `{:ok, raw_response_pb}`. 2. Adds the extra raw response check so that `append/3` returns `{:error, raw_unexpected_version_response_pb}` if there is the wrong expected version response AND raw flag set. If I just did ``` {:ok, response} when raw? == true -> {:ok, response} ``` An `{:ok, raw_unexpected_version_response_pb}` could have been returned on unexpected version error response.
Configuration menu - View commit details
-
Copy full SHA for f2c5fb4 - Browse repository at this point
Copy the full SHA f2c5fb4View commit details
Commits on May 7, 2024
-
fix:
append/3
returns{:ok, raw_resp}
for all`raw?: true` cases regardless of `:success` or `:wrong_expected_version` Also, cleans up the test cases to use `Streams.append_resp` pattern matching.
Configuration menu - View commit details
-
Copy full SHA for 02e9ba3 - Browse repository at this point
Copy the full SHA 02e9ba3View commit details
Commits on May 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a291c79 - Browse repository at this point
Copy the full SHA a291c79View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.